Description

Fidget-Spinner

opened on May 13, 2022

Issue body actions

Sorry if I should be raising this issue over at https://github.com/zware/codespeed instead, but both the speed-python and bb-benchmark-machines have not updated their results since May 7. Results page for both are empty since that date.

https://speed.python.org/timeline/?exe=12&base=&ben=2to3&env=1&revs=50&equid=off&quarts=on&extr=on

Activity

1. pablogsal commented on May 13, 2022

   

   pablogsal

   on May 13, 2022

   Member

   More actions

   It is likely that another package is broken by changes we did and tests are not running for said package. I will investigate

   Reacted by Ken Jin
2. methane commented on May 14, 2022

   

   methane

   on May 14, 2022

   Member

   More actions

   greenlet is failed to build. There are two types of errors.

         In file included from /home/methane/local/py312/include/python3.12/Python.h:38,
                          from src/greenlet/greenlet.cpp:14:
         src/greenlet/greenlet_refs.hpp: In member function ‘void greenlet::refs::PyErrPieces::normalize()’:
         /home/methane/local/py312/include/python3.12/pyport.h:30:25: error: invalid cast from type ‘greenlet::refs::OwnedErrPiece’ to type ‘const PyObject*’ {aka ‘const _object*’}
            30 |        const_cast<type>(reinterpret_cast<const type>(expr))
               |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         /home/methane/local/py312/include/python3.12/object.h:107:28: note: in expansion of macro ‘_Py_CAST’
           107 | #define _PyObject_CAST(op) _Py_CAST(PyObject*, (op))
               |                            ^~~~~~~~
         /home/methane/local/py312/include/python3.12/object.h:781:41: note: in expansion of macro ‘_PyObject_CAST’
           781 | #  define PyType_Check(op) PyType_Check(_PyObject_CAST(op))
               |                                         ^~~~~~~~~~~~~~
         /home/methane/local/py312/include/python3.12/pyerrors.h:57:6: note: in expansion of macro ‘PyType_Check’
            57 |     (PyType_Check((x)) &&                                               \
               |      ^~~~~~~~~~~~
         src/greenlet/greenlet_refs.hpp:993:17: note: in expansion of macro ‘PyExceptionClass_Check’
           993 |             if (PyExceptionClass_Check(type)) {
               |                 ^~~~~~~~~~~~~~~~~~~~~~
   

         In file included from /home/methane/local/py312/include/python3.12/Python.h:38,
                          from src/greenlet/greenlet.cpp:14:
         src/greenlet/greenlet_thread_state.hpp: In destructor ‘greenlet::ThreadState::~ThreadState()’:
         /home/methane/local/py312/include/python3.12/pyport.h:30:25: error: invalid cast from type ‘greenlet::refs::BorrowedObject’ {aka ‘greenlet::refs::BorrowedReference<_object, greenlet::refs::NoOpChecker>’} to type ‘const PyObject*’ {aka ‘const _obje
   ct*’}
            30 |        const_cast<type>(reinterpret_cast<const type>(expr))
               |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         /home/methane/local/py312/include/python3.12/object.h:107:28: note: in expansion of macro ‘_Py_CAST’
           107 | #define _PyObject_CAST(op) _Py_CAST(PyObject*, (op))
               |                            ^~~~~~~~
         /home/methane/local/py312/include/python3.12/object.h:266:59: note: in expansion of macro ‘_PyObject_CAST’
           266 | #  define PyObject_TypeCheck(ob, type) PyObject_TypeCheck(_PyObject_CAST(ob), type)
               |                                                           ^~~~~~~~~~~~~~
         /home/methane/local/py312/include/python3.12/methodobject.h:17:31: note: in expansion of macro ‘PyObject_TypeCheck’
            17 | #define PyCFunction_Check(op) PyObject_TypeCheck(op, &PyCFunction_Type)
               |                               ^~~~~~~~~~~~~~~~~~
         src/greenlet/greenlet_thread_state.hpp:400:33: note: in expansion of macro ‘PyCFunction_Check’
           400 |                              && PyCFunction_Check(refs.at(0))
               |                                 ^~~~~~~~~~~~~~~~~
   
3. methane commented on May 15, 2022

   

   methane

   on May 15, 2022

   Member

   More actions

   ref: python/cpython#92138
4. tacaswell commented on May 17, 2022

   

   tacaswell

   on May 17, 2022

   More actions

   xref python-greenlet/greenlet#301 / python-greenlet/greenlet#302
5. corona10 commented on May 22, 2022

   

   corona10

   on May 22, 2022

   Member

   More actions

   https://speed.python.org/changes/?rev=e5d8dbdd30&exe=12&env=1

   Now the result is published after merging python/cpython@5b71b51,
   I close this issue.

   Reacted by Ken Jin
6. corona10

   closed this as completedon May 22, 2022

Issue actions