GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add benchmark to measure gc collection of a big chain of cycles by pablogsal · Pull Request #243 · python/pyperformance

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 7, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested review from ericsnowcurrently, markshannon and mdboom November 7, 2022 14:26
@pablogsal

pablogsal commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

More to come, I will create a PR per benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon reviewed Nov 7, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOI do you have any numbers as to what fraction of the runtime this spends in GC?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread pyperformance/data-files/benchmarks/bm_gc_collect/run_benchmark.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Nov 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

OOI do you have any numbers as to what fraction of the runtime this spends in GC?

By definition all of it, as the benchmark is only measuring the gc.collect() call for the destruction of all the cycles.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal force-pushed the gc1 branch from e7ff07a to d894194 Compare November 7, 2022 14:48
@pablogsal
Add benchmark to measure gc collection of a big chain of cycles
607aa20 
Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the gc1 branch from d894194 to 607aa20 Compare November 7, 2022 14:49
ericsnowcurrently
ericsnowcurrently approved these changes Nov 7, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal merged commit 6d10e48 into python:main Nov 7, 2022
@pablogsal
pablogsal deleted the gc1 branch November 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@mdboom mdboom Awaiting requested review from mdboom

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @ericsnowcurrently @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.