GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Extend async tree benchmarks to cover eager task execution by itamaro · Pull Request #279 · python/pyperformance

Conversation

@itamaro

@itamaro itamaro commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

goes along with python/cpython#97696 (implemented in python/cpython#102853)

this change to pyperformance was used to measure the impact of the eager task execution feature.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
Create a separate set of benchmarks for asyncio eager execution using…
6d05680 
… the eager task factory (when available)
@itamaro itamaro mentioned this pull request Apr 21, 2023
gh-97696: asyncio eager tasks factory python/cpython#102853
Merged
@corona10
corona10 requested a review from kumaraditya303 April 21, 2023 23:33
@willingc

willingc commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

LGTM. Thanks @itamaro
itamaro reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
willingc
willingc approved these changes Apr 26, 2023
View reviewed changes
@itamaro

itamaro commented May 1, 2023

Copy link
Copy Markdown
Contributor Author

with python/cpython#102853 merged, I think this PR can be merged now so we can continue benchmarking this feature
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 self-assigned this May 6, 2023
@itamaro itamaro mentioned this pull request May 7, 2023
asyncio gather vs TaskGroup in async_tree benchmarks #287
Closed
kumaraditya303
kumaraditya303 reviewed May 8, 2023
View reviewed changes
Comment thread pyperformance/data-files/benchmarks/bm_async_tree/bm_async_tree_cpu_io_mixed.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed May 8, 2023
View reviewed changes
Comment thread pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@itamaro
itamaro requested a review from kumaraditya303 May 8, 2023 15:56
kumaraditya303
kumaraditya303 reviewed May 9, 2023
View reviewed changes
Comment thread pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Update pyperformance/data-files/benchmarks/bm_async_tree/run_benchmar…
f09f5c1 
…k.py
kumaraditya303
kumaraditya303 approved these changes May 9, 2023
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit 3615f18 into python:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@itamaro @willingc @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.