GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-287: Add TaskGroups variants to async_tree benchmarks by itamaro · Pull Request #293 · python/pyperformance

Conversation

@itamaro

@itamaro itamaro commented May 27, 2023

Copy link
Copy Markdown
Contributor

This PR adds 8 new async_tree benchmark variants covering TaskGroups usage for the 8 original variants.
In addition, I also added asyncio tags to all these benchmarks, and added a requires-python field to restrict the TaskGroups variants to >=3.11 and the eager variants to >=3.12.

fixed gh-287

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
itamaro added 3 commits May 27, 2023 14:09
@itamaro
Mark all eager variants of async_tree benchmark as require Python>=3.12
e06a8a7
@itamaro
Add "asyncio" tag to all async_tree benchmarks
734b2be
@itamaro
Add TaskGroups variants to all async_tree benchmarks
3ab4a54
@itamaro

itamaro commented May 27, 2023

Copy link
Copy Markdown
Contributor Author

cc @kumaraditya303 you were interested in this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed May 28, 2023
View reviewed changes
Comment thread pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
itamaro added 2 commits May 28, 2023 00:16
@itamaro
Actually use TaskGroup in the tg variant
d93e0ff
@itamaro
Append "_tg" to benchmark name in runner.bench_async_func call
1d6bf06
@kumaraditya303
kumaraditya303 requested a review from mdboom May 29, 2023 12:58
kumaraditya303
kumaraditya303 approved these changes Jun 13, 2023
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit c2e1adb into python:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@mdboom mdboom Awaiting requested review from mdboom

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asyncio gather vs TaskGroup in async_tree benchmarks

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@itamaro @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.