GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — Fix `bm_fastapi` failing when an HTTP proxy is configured by sendaoYan · Pull Request #505 · python/pyperformance Conversation
Contributor
Fixes #504 ProblemThe The benchmark starts a uvicorn server on FixCreate the client with async with httpx.AsyncClient(trust_env=False) as client: This is correct for this benchmark because it only ever connects to its own Only TestingReproduced by running the benchmark with proxy environment variables inherited $ python -m pyperformance run bm_fastapi --inherit-environ http_proxy,https_proxy,no_proxy
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionshttpx.AsyncClient() reads HTTP_PROXY/HTTPS_PROXY/NO_PROXY from the
environment by default. When a proxy is set, the benchmark routes
requests to its local 127.0.0.1 server through that proxy, which cannot
reach the loopback server and returns 503 Service Unavailable, causing
the benchmark to fail ("Benchmark died").
Pass trust_env=False since the benchmark only ever talks to localhost.
sendaoYan
force-pushed
the
fix-fastapi-proxy
branch
from
05d1fe2 to
142b5ec
Compare
savannahostrowski
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, good catch! I’m happy to merge this once #502 is in and CI is green. That should fix the unrelated Tornado/PyPy test failure! Thank you!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. bm_fastapi fails with "503 Service Unavailable" when a proxy is configured
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |