GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use date-based release numbers by theacodes · Pull Request #11 · python/python-docs-theme

Conversation

@theacodes

@theacodes theacodes commented Feb 2, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jon Wayne Parrott
Use date-based release numbers
2e8266f
@theacodes
theacodes requested review from Mariatta and ncoghlan February 2, 2018 05:28
@theacodes theacodes mentioned this pull request Feb 2, 2018
Make this available in PyPI? #5
Closed
ncoghlan
ncoghlan approved these changes Feb 2, 2018
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (although I'd suggest "year.month[.serial]" for the comment, since the most likely reason for multiple releases in a single month is because there was a build-breaking bug in one of them)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jon Wayne Parrott
Update setup.py
13f9ec6
@theacodes

theacodes commented Feb 2, 2018

Copy link
Copy Markdown
Collaborator Author

Good point, done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theacodes
theacodes merged commit 2a7d0cc into master Feb 2, 2018
@theacodes
theacodes deleted the jonparrott-date-based-releases branch February 2, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes
@Mariatta Mariatta Awaiting requested review from Mariatta

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@theacodes @ncoghlan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.