GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simplify release process. by JulienPalard · Pull Request #112 · python/python-docs-theme

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Mar 11, 2023

Copy link
Copy Markdown
Member

Closes #111.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard
Simplify release process.
6eb45f5
m-aciek
m-aciek approved these changes Mar 11, 2023
View reviewed changes
ezio-melotti
ezio-melotti reviewed Mar 12, 2023
View reviewed changes
Comment thread CONTRIBUTING.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
pradyunsg
pradyunsg reviewed Mar 12, 2023
View reviewed changes

@pradyunsg pradyunsg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing references to files that no longer exist is a worthwhile improvement!

I do think it's useful to have the .dev suffix on in-development copies though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard

JulienPalard commented Mar 15, 2023

Copy link
Copy Markdown
Member Author

I do think it's useful to have the .dev suffix on in-development copies though.

I'd be happy if you could teach me how it's useful (or sharing me a few links explaining your view, so I can learn myself) could you?

Anyway, if we keep the ".dev" I think we'll have to change the way we're doing it, as according to PEP 440 the .dev is ordered before its "non-dot-dev" courterpart. Maybe we should use .post.dev so it gets ordered after?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard
JulienPalard merged commit 09d972d into main Apr 17, 2023
@JulienPalard
JulienPalard deleted the mdk-simplify-release branch April 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradyunsg pradyunsg pradyunsg left review comments
@ezio-melotti ezio-melotti ezio-melotti left review comments
+1 more reviewer
@m-aciek m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is suffixing version in the dev tree with dev usefull to someone?

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JulienPalard @pradyunsg @m-aciek @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.