GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Override font for .sig for consistency with other code blocks by Kwpolska · Pull Request #121 · python/python-docs-theme

Conversation

@Kwpolska

@Kwpolska Kwpolska commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

The basic.css Sphinx stylesheet introduces a .sig rule, which sets some monospace fonts for the signature. The pydoctheme.css stylesheet has its own list of fonts, applied to some other elements, but not .sig. The result is an inconsistency on Windows systems with both Cascadia Mono and Consolas installed (I believe that happens in a default Windows 11 install). Compare the glyphs for 64 in the function signature and in the code block below it:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Kwpolska
Override font for .sig for consistency with other code blocks
94de857
@ghost

ghost commented Mar 25, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Mar 27, 2023

Copy link
Copy Markdown
Member

Would you mind showing the "before" and "after" screenshots of how it looks like with/without this change? Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kwpolska

Kwpolska commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

Sure. Before on the left, after on the right:

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Apr 17, 2023
View reviewed changes
@pradyunsg pradyunsg mentioned this pull request Apr 17, 2023
Releasing v2023.5 #126
Merged
@JulienPalard
JulienPalard merged commit aaca238 into python:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Kwpolska @Mariatta @hugovk @JulienPalard
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.