GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove searchbox ID from form by septatrix · Pull Request #124 · python/python-docs-theme

Conversation

@septatrix

@septatrix septatrix commented Apr 12, 2023 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #117.

The "Hide Search Matches" was not properly integrated into the layout, removing the ID reverts it to the previous behaviour where the toggle was suppressed.

Ideally we would have this working properly, however, sphinx sets this based on ID and we have more than one search forms so this would not show up properly (at the top and bottom of the desktop layout, and one in the mobile layout). With some CSS trickery it might be possible to reuse a single form element for the desktop and mobile layout such that this could be reasonably supported (and do without the toggle for the search form at the bottom) though this is a decent bit more complex and I am currently short on time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@septatrix
Remove searchbox id from form (fixes python#117)
14e362f
@septatrix septatrix mentioned this pull request Apr 12, 2023
Dark theme: "Hide Search Matches" shown on mobile #117
Closed
@hugovk hugovk changed the title Remove searchbox id from form (fixes #117) Remove searchbox ID from form Apr 13, 2023
hugovk
hugovk approved these changes Apr 13, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk merged commit b134985 into python:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dark theme: "Hide Search Matches" shown on mobile

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@septatrix @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.