GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Dark mode: add class to invert image brightness by hugovk · Pull Request #128 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Apr 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For python/cpython#103960.

Re: #44 (comment).

Add a class to invert image brightness (but not contrast), similar to how we handled it for the PEPs repo: python/peps#2409 and python/peps#2949.

We can then add this class to images like this:

.. figure:: hashlib-blake2-tree.png
   :alt: Explanation of tree mode parameters.
   :class: invert-in-dark-mode

Which changes this:

Details image

Into:

Details image

And light mode remains unchanged:

Details image

This can be merged before or after python/cpython#103983.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
Dark mode: add class to invert image brightness
cfa1780
This was referenced Apr 28, 2023
Documentation: dark theme & images python/cpython#103960
Closed
Dark theme #44
Merged
gh-103960: Dark mode: invert image brightness python/cpython#103983
Merged
Releasing v2023.5 #126
Merged
pradyunsg
pradyunsg approved these changes Apr 30, 2023
View reviewed changes
@pradyunsg
pradyunsg merged commit 5646c93 into python:main Apr 30, 2023
@hugovk
hugovk deleted the dark-mode-img.invert-in-dark-mode branch April 30, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @pradyunsg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.