GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Enable search shortcuts by miketheman · Pull Request #135 · python/python-docs-theme Conversation
|
|
Sadly, this doesn't work 100% because we create multiple searchbox elements per page with our own layout.
(there's one more, I haven't hunted it down yet) I'm guessing this would be a little more involved in restructuring the layout template to reduce the duplication, and thus enable taking advantage of their already-supplied functionality. If there's appetite for that, I'll pursue it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Nice, I didn't know this was a Sphinx option, I'd prefer to use this than the custom JavaScript in #131. (Although there's not much JS in there.) https://www.sphinx-doc.org/en/master/usage/theming.html says:
Does it really default to We don't have |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Turns out, it does default to True, so this PR is also unnecessary! Pressing the slash key today does in fact work, however it places the focus on the hidden mobile nav search box since it appears first in the HTML. 🤔 I wonder if we still need an explicit mobile nav, or if the signature could be changed so it still works correctly but does not appear first in the selector. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Even simpler! #141 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.