GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not append asset hashes on Sphinx 7.1+ by pradyunsg · Pull Request #137 · python/python-docs-theme

Conversation

@pradyunsg

@pradyunsg pradyunsg commented Jul 26, 2023

Copy link
Copy Markdown
Member

Closes #136

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pradyunsg
Do not append asset hashes on Sphinx 7.1+
ef296e2 
The relevant functionality has been added to Sphinx natively.
@pradyunsg

pradyunsg commented Jul 26, 2023

Copy link
Copy Markdown
Member Author

Whoops, I accidentally used the wrong repo to send the branch to! Sorry about that!
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jul 26, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like pradyunsg/furo@a92dd0c, thank you!

Great that Sphinx has included this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner
AA-Turner reviewed Jul 26, 2023
View reviewed changes
Comment thread python_docs_theme/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pradyunsg
Rework based on suggested changes
c7958da 
Sphinx 7.1 added the relevant functionality natively.
@pradyunsg
pradyunsg requested review from AA-Turner and hugovk July 26, 2023 21:14
@pradyunsg

pradyunsg commented Jul 26, 2023

Copy link
Copy Markdown
Member Author

(requesting a new review, since the implementation changed)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jul 27, 2023
View reviewed changes
AA-Turner
AA-Turner approved these changes Jul 27, 2023
View reviewed changes
@hugovk
hugovk merged commit a100c04 into main Jul 29, 2023
@hugovk
hugovk deleted the sphinx-7-1-0 branch July 29, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Theme broken with Sphinx 7.1.0

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pradyunsg @hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.