GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't let long code literals extend beyond the right side of the screen by hugovk · Pull Request #139 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Jul 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #129.

With mobile, compare:

  • https://docs.python.org/3.13/whatsnew/3.12.html
  • https://python-docs-theme-previews--139.org.readthedocs.build/en/139/whatsnew/3.12.html
Before After

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Don't let long code literals extend beyond the right side of the screen
6787cd6
@hugovk hugovk added the bug label Jul 27, 2023
@hugovk
hugovk marked this pull request as ready for review July 27, 2023 11:47
@hugovk hugovk mentioned this pull request Jul 27, 2023
Wrap lines of code to prevent empty horizontal scroll #129
Closed
AA-Turner
AA-Turner approved these changes Jul 27, 2023
View reviewed changes
@pradyunsg

pradyunsg commented Jul 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In Furo, I went ahead and set break-word on the entire content container in pradyunsg/furo@c8b51d0

That makes it so that no regular text/markup, including really long one-word titles don't trigger a rewrap by default, would have an overflow beyond that element.

Do you think it's worth adopting a similar model here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jul 28, 2023

Copy link
Copy Markdown
Member Author

Yes, that sounds better, would you like to update this PR or create a new one?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Apply no-wrap to container
b2bd518
@hugovk

hugovk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

Updated, how does this look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pradyunsg
pradyunsg approved these changes Jul 30, 2023
View reviewed changes

@pradyunsg pradyunsg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@hugovk
hugovk merged commit c98e976 into python:main Jul 30, 2023
@hugovk
hugovk deleted the mobile-wrap-long-code-literals branch July 30, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrap lines of code to prevent empty horizontal scroll

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @pradyunsg @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.