GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Only apply underline offset to code formatting for underline visibility by hugovk · Pull Request #171 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Feb 3, 2024

Copy link
Copy Markdown
Member

Helps #168.

In #160 we added underlines to links, with an extra offset to help make sure underscores (_) are not obscured by the underlines.

(In #166 we reduced the amount of offset.)

We only really need the offset for code formatting, where underscores often show up, so we can use the default offset for normal links and only apply an extra offset for code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 3 commits February 3, 2024 23:26
@hugovk
Only apply underline offset to code formatting for underline visibility
2f38e86
@hugovk
Remove debugging
98b94c5
@hugovk
Add missing bracket
2dd4e77
ezio-melotti
ezio-melotti approved these changes Feb 4, 2024
View reviewed changes

@ezio-melotti ezio-melotti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment explaining what these two rules do, otherwise LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
hugovk added 3 commits February 4, 2024 19:17
@hugovk
Merge branch 'main' into text-underline-offset
9771130
@hugovk
Add comments
2f3f86e
@hugovk
Whitespace between CSS blocks
fbf2bf8
@hugovk
hugovk merged commit 69039fb into python:main Feb 4, 2024
@hugovk
hugovk deleted the text-underline-offset branch February 4, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.