GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Only show 'Last updated on ...' when `last_updated` defined by hugovk · Pull Request #183 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Mar 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #182.

We were always showing it:

{% trans last_updated=last_updated|e %}Last updated on {{ last_updated }}.{% endtrans %}

Instead, we should check the variable first:

{%- if last_updated %}
  {% trans last_updated=last_updated|e %}Last updated on {{ last_updated }}.{% endtrans %}
{%- endif %}

This is also what Sphinx does:

https://github.com/sphinx-doc/sphinx/blob/2e05fd2ffe70b2cfd48bdb9e35eecac43b46637d/sphinx/themes/basic/layout.html#L211-L213

Also add some newlines around other if blocks to make them clearer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 2 commits March 25, 2024 15:43
@hugovk
Only show 'Last updated on ...' when last_updated defined
fe6a243
@hugovk
Add newlines to make if blocks clear
5c6c0b4
@hugovk hugovk added the bug label Mar 25, 2024
@hugovk hugovk changed the title Only show 'Last updated on ...' when last_updated defined Only show 'Last updated on ...' when last_updated defined Mar 25, 2024
ezio-melotti
ezio-melotti approved these changes Mar 25, 2024
View reviewed changes
@hugovk
hugovk merged commit 439dd95 into python:main Mar 25, 2024
@hugovk
hugovk deleted the fix-last-updated-on-none branch March 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer: "Last updated on None"

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.