GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use system font stack for all code by hugovk · Pull Request #186 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Apr 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Follow on from #176.

I missed one of the code font styles.

It's subtle but can be seen in this table:

  • https://docs.python.org/3.13/library/asyncio-task.html#waiting-primitives

The left column has the old font (e.g. asyncio.FIRST_COMPLETED), but the right has the new one (e.g. the ALL_COMPLETED link).

Preview:

  • https://python-docs-theme-previews--186.org.readthedocs.build/en/186/library/asyncio-task.html#waiting-primitives

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@hugovk
Use system font stack
059b2c7
pradyunsg
pradyunsg approved these changes Apr 8, 2024
View reviewed changes
ezio-melotti
ezio-melotti approved these changes Apr 9, 2024
View reviewed changes
@pradyunsg
pradyunsg merged commit 9cb011f into python:main Apr 9, 2024
@hugovk hugovk added the bug label Apr 9, 2024
@hugovk hugovk changed the title Use system font stack Use system font stack for code Apr 9, 2024
@hugovk
hugovk deleted the sfs2 branch April 9, 2024 07:41
@hugovk hugovk changed the title Use system font stack for code Use system font stack for all code Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @pradyunsg @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.