GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Use different colour for 'Return value: Borrowed reference' by hugovk · Pull Request #188 · python/python-docs-theme Conversation
|
FYI As a color blind person, I don't see the difference between "Borrowed reference" and "New reference" colors in the light mode. Well, I'm also color blind, so my opinion may not matter :-) In the dark mode, I see clearly that the two colors are very different. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
If you’re reusing existing colors, how about you centralize their definition as a CSS variables and then use it from both your new CSS rules and the old ones that originally defined the color? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Good idea, shall we also replace the pale green for the other "Return value" with the "New in version" green? The light mode ones are much closer, but we could replace one with the other here too? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Updated: Suggestions for better variable names welcome :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion regarding naming, but I like the change! Personally, I would prefer borrowed references to be labelled as "bad", but that is a different discussion.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This is now deployed: https://docs.python.org/3/c-api/exceptions.html |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.