GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Add backgrounds and borders to admonitions by hugovk · Pull Request #190 · python/python-docs-theme Conversation
Member
Only some of the "admonitions" have backgrounds and borders, giving them slightly different indentations: We're missing backgrounds and borders for most of them: Other themes have them for all:
Let's also fill in the gaps. Before
After
Screenshots using this from the Kitchen Sink: Details.. Copyright (c) 2021 Pradyun Gedam Licensed under Creative Commons Attribution-ShareAlike 4.0 International License SPDX-License-Identifier: CC-BY-SA-4.0 =========== Admonitions =========== Sphinx provides several different types of admonitions. ``topic`` ========= .. topic:: This is a topic. This is what admonitions are a special case of, according to the docutils documentation. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``admonition`` ============== .. admonition:: The one with the custom titles It's got a certain charm to it. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``attention`` ============= .. attention:: Climate change is real. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``caution`` =========== .. caution:: Cliff ahead: Don't drive off it. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``danger`` ========== .. danger:: Mad scientist at work! We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``error`` ========= .. error:: Does not compute. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``hint`` ======== .. hint:: Insulators insulate, until they are subject to ______ voltage. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``important`` ============= .. important:: Tech is not neutral, nor is it apolitical. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``note`` ======== .. note:: This is a note. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``seealso`` =========== .. seealso:: Other relevant information. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``tip`` ======= .. tip:: 25% if the service is good. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more. ``warning`` =========== .. warning:: Reader discretion is strongly advised. We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/>`_, and more.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
nedbat
reviewed
Uh oh!
There was an error while loading. Please reload this page.
nedbat
reviewed
Uh oh!
There was an error while loading. Please reload this page.
nedbat
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I left a few nitpicky comments, and I also have some additional bikeshedding, since the color choice of some admonition seems somewhat arbitrary to me:
We should also check how they look on some real-world example, and see if the colors (and maybe the boxes too) are too distracting. This might actually be the reason why they weren't added in the first place (maybe we should check with the original author too and ask them why they made that choice). We might also want to leave the bikeshedding for a separate PR (especially if you just copied the colors from another theme) as not to stall this PR.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. …ges and conflicts with background-color
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |