GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove trailing space from link by StanFromIreland · Pull Request #269 · python/python-docs-theme

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Sep 14, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Current:
image

With PR:
image

📚 Documentation preview 📚: https://python-docs-theme-previews--269.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
commit
54b3d8b
@StanFromIreland
StanFromIreland requested a review from hugovk September 14, 2025 12:49
ezio-melotti
ezio-melotti reviewed Sep 14, 2025
View reviewed changes
Comment thread python_docs_theme/layout.html Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Alternative approach
e18f312
@StanFromIreland
StanFromIreland requested a review from ezio-melotti September 14, 2025 17:42
@hugovk

hugovk commented Sep 15, 2025

Copy link
Copy Markdown
Member

It doesn't show in the render for Chrome, but can we remove the leading space before "Copyright"?

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

That's interesting, I can also remove the leading one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Review
fe9cd73
@StanFromIreland

StanFromIreland commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

Done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Sep 15, 2025
View reviewed changes
Comment thread python_docs_theme/layout.html Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland added 2 commits September 15, 2025 17:51
@StanFromIreland
Review
c72b73c
@StanFromIreland
Commit
b19d8dc
@StanFromIreland
StanFromIreland requested a review from hugovk September 15, 2025 17:00
@hugovk
hugovk merged commit 6ea8ff6 into python:main Sep 16, 2025
@hugovk

hugovk commented Sep 16, 2025

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanFromIreland @hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.