GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for Python 3.15 by hugovk · Pull Request #282 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Nov 26, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The earlier approach was something like:

      matrix:
        branch: ["main", "3.14", "3.13", "3.12"]
...
          python-version: ${{ matrix.branch == 'main' && '3.15' || matrix.branch }}
...
          --branches ${{ matrix.branch }}

Which do you prefer?

📚 Documentation preview 📚: https://python-docs-theme-previews--282.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Add support for Python 3.15
6444b63
@hugovk hugovk added enhancement github_actions Pull requests that update GitHub Actions code labels Nov 26, 2025
AA-Turner
AA-Turner reviewed Nov 26, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were me, I'd probably duplicate the jobs -- one for released & one for in-development.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ezio-melotti
ezio-melotti approved these changes Nov 28, 2025
View reviewed changes
Comment thread .github/workflows/tests.yml
Comment on lines +16 to +18
include:
- python-version: "3.15"
branch: "main"

@ezio-melotti ezio-melotti Nov 28, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible improvement is to compute the branch and extra opts once and assign them to env vars:

Suggested change
include:
- python-version: "3.15"
branch: "main"
include:
- python-version: "3.15"
branch: "main"
extra_opts: '--select-output no-html'
env:
# set the branch name to either 'main' or the version number
BRANCH: ${{ matrix.branch || matrix.version }}
# define optional extra options if specified
EXTRA_OPTS: ${{ matrix.extra_opts || '' }}

This keeps all the data and logic closer and avoids duplication. However we only need the branch and the extra opts once in the workflow, so your less-verbose solution is fine too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Nov 28, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is quite a bit more verbose, let's stick with the current version. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/tests.yml
Comment on lines +44 to +45
--branches ${{ matrix.branch || matrix.python-version }}
${{ matrix.branch == 'main' && '--select-output no-html' || '' }}

@ezio-melotti ezio-melotti Nov 28, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--branches ${{ matrix.branch || matrix.python-version }}
${{ matrix.branch == 'main' && '--select-output no-html' || '' }}
--branches env.BRANCH env.EXTRA_OPTS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk merged commit 4e36f99 into python:main Nov 28, 2025
15 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the add-3.15 branch November 28, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @AA-Turner @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.