GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix install from sdist for RTD by hugovk · Pull Request #320 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Jul 27, 2026

Copy link
Copy Markdown
Member

The Makefile wasn't quite working as intended. This is used for RTD builds.

Before

It intends to build an sdist and then install from that. But:

find: ‘dist/python-docs-theme-*.tar.gz’: No such file or directory

https://app.readthedocs.org/projects/python-docs-theme-previews/builds/33742569/

This is because the filenames are now normalised and look like python_docs_theme-2026.4.tar.gz

But anyway, it was evaluating this before even running $(PYTHON) -m build:

PACKAGE_ABS_PATH = $(shell pwd)/$(shell find dist/python-docs-theme-*.tar.gz)

So even the correct name wouldn't find it.

But it was then installing from PyPI as part of the normal docs build:

Collecting python-docs-theme==2026.4 (from pylock.toml)
  Downloading python_docs_theme-2026.4-py3-none-any.whl (73 kB)

And then ./venv/bin/pip install $(PACKAGE_ABS_PATH) was just doing an install from the current directory, so we ended up with the local dev version after all:

Building wheels for collected packages: python-docs-theme
  Building wheel for python-docs-theme (pyproject.toml): started
  Building wheel for python-docs-theme (pyproject.toml): finished with status 'done'
  Created wheel for python-docs-theme: filename=python_docs_theme-2026.4-py3-none-any.whl size=47033 sha256=2ef5cfd56d04c28218e833d12a81b068b485bef38818c88da1b99c670bcb2ce3
  Stored in directory: /tmp/pip-ephem-wheel-cache-36pb2g5u/wheels/9c/8a/8b/1187bbb4cb469b4e87f8aee1562b67ba81301f0ababe695fea
Successfully built python-docs-theme
Installing collected packages: python-docs-theme
  Attempting uninstall: python-docs-theme
    Found existing installation: python-docs-theme 2026.4
    Uninstalling python-docs-theme-2026.4:
      Successfully uninstalled python-docs-theme-2026.4
Successfully installed python-docs-theme-2026.4

After

Fix installing from sdist.

Remove PACKAGE_ABS_PATH and let the shell expand the normalised glob when pip runs, after the sdist is built. Also clear dist/ before building, so a stale tarball from a previous build can't make the glob match two files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Fix install from sdist for RTD
8c8d3a7
@read-the-docs-community

read-the-docs-community Bot commented Jul 27, 2026

Copy link
Copy Markdown

Documentation build overview

📚 python-docs-theme-previews | 🛠️ Build #33777084 | 📁 Comparing 8c8d3a7 against latest (3209b93)

  🔍 Preview build  

11 files changed · ± 11 modified

± Modified

  • contents.html
  • download.html
  • license.html
  • library/asyncio-eventloop.html
  • library/ctypes.html
  • library/difflib.html
  • library/exceptions.html
  • library/logging.handlers.html
  • library/stdtypes.html
  • whatsnew/3.16.html
  • and 1 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland approved these changes Jul 27, 2026
View reviewed changes
@StanFromIreland
StanFromIreland merged commit d1d0e1b into python:main Jul 27, 2026
14 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Jul 27, 2026
Prepare 2026.7 release #319
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.