GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add a configuration for license URL. by JulienPalard · Pull Request #90 · python/python-docs-theme

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Nov 7, 2021

Copy link
Copy Markdown
Member

closes #89

You're right @merwok, the assignment were reversed (and useless so they were not introducing a bug).

I made the link to the license configurable, so we could add license_url cpython side to point to it (near it's issues_url in Doc/config.py)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 7, 2021
@CAM-Gerlach

CAM-Gerlach commented Dec 11, 2021

Copy link
Copy Markdown
Member

Would make sense to have at least have a fallback to the previous behavior if the theme variables are undefined, as was implemented on #67 per my suggestion there, for backward compatibility and to follow the approach there for the copyright link? Other than that, this is a pretty important change, since the link is broken at present.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard

JulienPalard commented Dec 11, 2021

Copy link
Copy Markdown
Member Author

The current "fallback" is just not to display the link, I'm not sure we can do better here. Do you have something better in mind?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach

CAM-Gerlach commented Dec 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Yeah, sorry for the delay—what I was suggesting you could do something like was done for the copyright URL right above it, fall back to a corrected version of the previous behavior, i.e. the hardcoded path, unless the existing behavior was always broken and never actually functioned as intended (which may be the case, I didn't trawl through the full commit history to check).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach CAM-Gerlach mentioned this pull request Dec 15, 2021
"See History and License" link redirects to current page pypa/pypa.io#73
Open
@JulienPalard

JulienPalard commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

I'm puzzeled: the current implementation works on some pages but not all. It works at least on:

  • https://docs.python.org/3.11/copyright.html
  • https://docs.python.org/3.11/license.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard

JulienPalard commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Hum, no, I'm just not awaken yet, on those page, it work like on many other pages: it redirects on the "Current page". In all cases it's a <a href="".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard
Add a configuration for license URL.
cbe799a
@JulienPalard

JulienPalard commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

I modified my PR a bit to avoid changing the msgid for translators.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard
JulienPalard merged commit 6c2b38f into python:master Jan 11, 2022
@JulienPalard
JulienPalard deleted the mdk-license-url branch January 11, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Empty history & license link in Python docs footer

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JulienPalard @CAM-Gerlach @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.