GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add PyCode_GetCode() function by vstinner · Pull Request #34 · python/pythoncapi-compat

Conversation

vstinner commented May 3, 2022

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add PyCode_GetCode() function

d3e2f86

vstinner commented May 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Wait until python/cpython#92168 is merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner marked this pull request as draft

May 3, 2022 11:37

vstinner mentioned this pull request

May 3, 2022

gh-92154: Expose PyCode_GetCode in the C API python/cpython#92168

Merged


          Update

98cde84

vstinner marked this pull request as ready for review

May 3, 2022 13:45

vstinner merged commit 85d1bd8 into python:main

May 3, 2022

vstinner deleted the code_getcode branch

May 3, 2022 13:49

Fidget-Spinner reviewed

May 3, 2022

View reviewed changes

Comment thread

docs/api.rst

		Python 3.11
		-----------

		.. c:function:: PyObject* PyCode_GetCode(PyObject *code)

Fidget-Spinner May 3, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: PyCodeObject *code not PyObject *code :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner May 3, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit bed155e.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Fidget-Spinner reviewed

May 3, 2022

View reviewed changes

Comment thread

pythoncapi_compat.h



		// gh-92154 added PyCode_GetCode() to Python 3.11.0b1
		#if PY_VERSION_HEX < 0x030B00B1 && !defined(PYPY_VERSION)

Fidget-Spinner May 3, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it matters, but this code will fail on one version: 3.11a7. In that version, co_code was removed, but there is no PyCode_GetCode.

I don't know what you should do here. Maybe exclude that version?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland May 3, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps #error with an explanatory message.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner May 3, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you should do here. Maybe exclude that version?

Alpha versions of Python 3.11 are not supported:

pythoncapi-compat/tests/test_pythoncapi_compat.py

Lines 152 to 157 in c9764f5

	# Implementing PyFrame_GetLocals() and PyCode_GetCode() require the
	# internal C API in Python 3.11 alpha versions
	if 0x30b0000 <= sys.hexversion < 0x30b00b1:
	version = sys.version.split()[0]
	print("SKIP TESTS: Python %s is not supported" % version)
	return

It's a deliberate choice to not pollute pythoncapi_compat.h with ugly code to tons of compatibility layers, whereas there are few users of Python alpha versions.

Perhaps #error with an explanatory message.

What I suggested to users who want to upgrade pythoncapi_compat.h before Python 3.11 beta1 is to copy the file and then remove the functions which cause compilation errors. It's being discussed at: #32

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland and Fidget-Spinner reacted with thumbs up emoji

All reactions

👍 2 reactions

erlend-aasland May 3, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner May 3, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against adding an #error if you consider that it will help users impacted by this issue.

Python 3.11 beta1 is scheduled in a few days.

Python 3.11 breaks tons of C API: https://docs.python.org/dev/whatsnew/3.11.html#c-api-changes

In the past, I tried first to add getter functions in one Python version, and only change the structure in the following Python version. Well, the optimization work broke many structures (PyThreadState, PyFrameObject, PyCodeObject). But after beta1, the API should be stable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland and Skylion007 reacted with thumbs up emoji

All reactions

👍 2 reactions

Reviewers

erlend-aasland

erlend-aasland left review comments

+1 more reviewer

Fidget-Spinner

Fidget-Spinner left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

vstinner commented May 3, 2022

Uh oh!

vstinner commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vstinner commented May 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.