GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add PyUnicode_EqualToUTF8() function by vstinner · Pull Request #78 · python/pythoncapi-compat

Conversation

@vstinner

@vstinner vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner marked this pull request as draft October 4, 2023 14:46
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

Wait until the API is added upstream: python/cpython#110297
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 4, 2023
gh-110289: C API: Add PyUnicode_EqualToUTF8() function python/cpython#110297
Merged
@serhiy-storchaka

serhiy-storchaka commented Oct 4, 2023

Copy link
Copy Markdown
Member

You need to at least save and restore the exception as in PyDict_GetItem().
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner marked this pull request as ready for review October 12, 2023 09:39
@vstinner
vstinner force-pushed the equalutf8 branch from ae5ad35 to 50be06c Compare October 12, 2023 09:53
@vstinner
Add PyUnicode_EqualToUTF8() function
5cca9a4 
Add PyUnicode_EqualToUTF8() and PyUnicode_EqualToUTF8AndSize()
functions.
@vstinner
vstinner force-pushed the equalutf8 branch from 50be06c to 5cca9a4 Compare October 12, 2023 09:57
@vstinner
vstinner merged commit 99ab0d3 into python:main Oct 12, 2023
@vstinner
vstinner deleted the equalutf8 branch October 12, 2023 10:00
@vstinner

vstinner commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

You need to at least save and restore the exception as in PyDict_GetItem().

Right, done. I added a test for that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.