GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add is_cli param to pydoc.pyi by Eclips4 · Pull Request #10331 · python/typeshed

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jun 19, 2023

Copy link
Copy Markdown
Member

As introduced in this PR, pydoc.doc and Helper.help now has an is_cli keyword parameter, which defaults to False.
It's has been backported to 3.11 branch, so I added a check for the version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
Add is_cli param
dc42448
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja approved these changes Jun 19, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll merge once new versions have been released and Github Actions picks them up

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4 reacted with thumbs up emoji Eclips4 reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
@hauntsaninja hauntsaninja added the status: deferred Issue or PR deferred until some precondition is fixed label Jun 19, 2023
@srittau
Merge branch 'main' into add_is_cli_param
b9a7aa6
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood

AlexWaygood commented Jun 21, 2023

Copy link
Copy Markdown
Member

Now that Python 3.12b3 has made its way to GitHub Actions, the lack of this parameter is causing our CI to fail on main (e.g. https://github.com/python/typeshed/actions/runs/5334685391/jobs/9666793887?pr=10277). But it'll still be a while until we get a 3.11 patch release that includes this parameter.

For now, I'm going to edit this PR so that it just includes the parameter on py312+. We can change the stub so that the parameter is also included on py311 when we get a py311 release that includes the parameter :)
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood added 2 commits June 21, 2023 14:43
@AlexWaygood
Merge branch 'main' into add_is_cli_param
5321d4b
@AlexWaygood
Just 3.12+ for now
914b6b3
@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Jun 21, 2023
@github-actions

github-actions Bot commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood merged commit f3a0be3 into python:main Jun 21, 2023
@Eclips4
Eclips4 deleted the add_is_cli_param branch June 25, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Eclips4 @AlexWaygood @hauntsaninja @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.