GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update asyncio.Stream.readuntil by bmerry · Pull Request #11755 · python/typeshed

Conversation

@bmerry

@bmerry bmerry commented Apr 14, 2024

Copy link
Copy Markdown
Contributor
  • Make use of ReadableBuffer to generalise the arguments accepted (implementing the suggestion made in a comment).
  • Support a tuple of separators in Python 3.13, as implemented in gh-81322: support multiple separators in Stream.readuntil cpython#16429 and gh-117722: Fix Stream.readuntil with non-bytes buffer objects cpython#117723.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bmerry and others added 2 commits April 14, 2024 10:30
@bmerry
Update asyncio.Stream.readuntil
70c300c 
- Make use of ReadableBuffer to generalise the arguments accepted
  (implementing the suggestion made in a comment).
- Support a tuple of separators in Python 3.13, as implemented in
  python/cpython#16429 and python/cpython#117723.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b5b1fb3
@bmerry bmerry mentioned this pull request Apr 14, 2024
Allow multiple separators in Stream.readuntil python/cpython#81322
Closed
@github-actions

This comment has been minimized.

Sign in to view
@bmerry
Fix previous commit
6f5c35d
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Apr 14, 2024
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and congratulations on getting that PR merged after only short five years. :) On issue below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/asyncio/streams.pyi Outdated
# Can be any buffer that supports len(); consider changing to a Protocol if PEP 688 is accepted
async def readuntil(self, separator: bytes | bytearray | memoryview = b"\n") -> bytes: ...
if sys.version_info >= (3, 13):
async def readuntil(self, separator: _ReaduntilBuffer | tuple[_ReaduntilBuffer] = b"\n") -> bytes: ...

@srittau srittau Apr 14, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async def readuntil(self, separator: _ReaduntilBuffer | tuple[_ReaduntilBuffer] = b"\n") -> bytes: ...
async def readuntil(self, separator: _ReaduntilBuffer | tuple[_ReaduntilBuffer, ...] = b"\n") -> bytes: ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bmerry bmerry Apr 14, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm always making that mistake with tuples. Fixed now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bmerry
Fix tuple[X] to tuple[X, ...]
a1ea3f1
@github-actions

github-actions Bot commented Apr 14, 2024

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes Apr 14, 2024
View reviewed changes
@srittau
srittau merged commit 9d234d9 into python:main Apr 14, 2024
@jgarvin jgarvin mentioned this pull request Jul 24, 2024
What is the correct way to subclass asyncio.StreamReader? #12423
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bmerry @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.