GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add python-gnupg stubs by lovetox · Pull Request #13465 · python/typeshed

Conversation

@lovetox

@lovetox lovetox commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@lovetox lovetox mentioned this pull request Feb 5, 2025
Add typing stubs vsajip/python-gnupg#248
Closed
@lovetox
Add python-gnupg stubs
4a71e56
@lovetox
lovetox force-pushed the gnupg branch from b7d12b6 to 4a71e56 Compare February 5, 2025 18:42
@lovetox lovetox mentioned this pull request Feb 5, 2025
Type stubs? vsajip/python-gnupg#247
Open
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Feb 26, 2025
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, notes below. Also:

  • Please add a comment for each Any explaining the valid types.
  • Instance variables initialized in __init__ should be added to all classes.
  • Default values should be the actual default values, not ... (unless they are complex).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stubs/python-gnupg/gnupg/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stubs/python-gnupg/gnupg/__init__.pyi
__author__: str = ...
__date__: str = ...

from typing import Protocol

@srittau srittau Feb 26, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be combined with the imports above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stubs/python-gnupg/gnupg/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stubs/python-gnupg/gnupg/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stubs/python-gnupg/gnupg/__init__.pyi
logger: logging.Logger = ...
fsencoding: str = ...

UNSAFE: re.Pattern[Any] = ...

@srittau srittau Feb 26, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is only defined on some platforms, I would just add gnupg.UNSAFE to @tests/stubtest_allowlist.txt.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stubs/python-gnupg/gnupg/__init__.pyi
Comment on lines +84 to +85
UID_INDEX: int = ...
FIELDS: list[str] = ...

@srittau srittau Feb 26, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stubs/python-gnupg/gnupg/__init__.pyi
FIELDS: list[str] = ...
def __init__(self, gpg: GPG) -> None: ...
def key(self, args: Any) -> None: ...
sec: Any = ...

@srittau srittau Feb 26, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sec: Any = ...
pub = key
sec = key

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stubs/python-gnupg/gnupg/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stubs/python-gnupg/gnupg/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stubs/python-gnupg/gnupg/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lovetox @srittau
Apply suggestions from code review
e8b03f8 
Co-authored-by: Sebastian Rittau <[email protected]>
@github-actions

github-actions Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Oct 9, 2025
View reviewed changes
Comment thread stubs/python-gnupg/gnupg/__init__.pyi
@@ -0,0 +1,257 @@
import logging
import re
from typing import Any

@hugovk hugovk Oct 9, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from typing import Any
from typing import Any, Final

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brianschubert

brianschubert commented Mar 14, 2026

Copy link
Copy Markdown
Collaborator

Marking this as a draft for now since CI isn't passing and the review above needs to be addressed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brianschubert
brianschubert marked this pull request as draft March 14, 2026 19:56
@lovetox

lovetox commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

I dont want to follow up on this, thanks
brianschubert reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lovetox lovetox closed this Mar 14, 2026
@hugovk hugovk mentioned this pull request Nov 10, 2026
Add stubs for python-gnupg #16757
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau requested changes
+1 more reviewer
@hugovk hugovk hugovk left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lovetox @brianschubert @srittau @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.