GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(types): cr_frame may be None by ashm-dev · Pull Request #14802 · python/typeshed

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

Closes #14780

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ashm-dev
fix(types): cr_frame may be None
2524cd9
@github-actions

This comment has been minimized.

Sign in to view
@ashm-dev

ashm-dev commented Sep 28, 2025

Copy link
Copy Markdown
Contributor Author

@srittau @sobolevn
Could you take a look at my PR when you have a chance?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn
sobolevn approved these changes Sep 28, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand it can only be None for 3.12+

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
sobolevn self-requested a review September 28, 2025 10:09
sobolevn
sobolevn requested changes Sep 28, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve is a misclick

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ashm-dev
fix
41133c4
@ashm-dev
ashm-dev requested a review from sobolevn September 28, 2025 11:50
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Sep 28, 2025
View reviewed changes
Comment thread stdlib/types.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev
fix
4e90e87
@ashm-dev
ashm-dev requested a review from AlexWaygood September 28, 2025 12:08
@github-actions

github-actions Bot commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes Sep 30, 2025
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
sobolevn
sobolevn approved these changes Sep 30, 2025
View reviewed changes
@sobolevn
sobolevn merged commit 284acd4 into python:main Sep 30, 2025
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev
ashm-dev deleted the gh-14780 branch September 30, 2025 10:12
@x42005e1f x42005e1f mentioned this pull request Jan 5, 2026
types.GeneratorType.gi_frame should be FrameType | None #15218
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes
@sobolevn sobolevn sobolevn approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

types.CoroutineType.cr_frame should be FrameType | None

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ashm-dev @srittau @sobolevn @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.