GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add asyncio 3.14 deprecations by max-muoto · Pull Request #15176 · python/typeshed

Conversation

@max-muoto

@max-muoto max-muoto commented Dec 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR adds the asyncio.iscoroutinefunction deprecations from #14289 with the only core change being that we only deprecate them for >= 3.11 due to @srittau's feedback here: #14074 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
max-muoto and others added 2 commits December 25, 2025 14:28
@max-muoto
Add asyncio 3.14 deprecations
a75f502
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5de657f
@github-actions

This comment has been minimized.

Sign in to view
@max-muoto
max-muoto marked this pull request as ready for review December 25, 2025 20:44
donbarbos
donbarbos reviewed Dec 26, 2025
View reviewed changes

@donbarbos donbarbos left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just suggestion about messages.
PR: python/cpython#122875

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/asyncio/coroutines.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/asyncio/coroutines.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/asyncio/coroutines.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/asyncio/coroutines.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
@max-muoto

max-muoto commented Dec 26, 2025

Copy link
Copy Markdown
Contributor Author

Thank you, just suggestion about messages. PR: python/cpython#122875

Good catch - would be best to follow the runtime messages here, will update.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
max-muoto and others added 4 commits December 26, 2025 13:26
@max-muoto @donbarbos
Update stdlib/asyncio/coroutines.pyi
a3a3c0f 
Co-authored-by: Semyon Moroz <[email protected]>
@max-muoto @donbarbos
Update stdlib/asyncio/coroutines.pyi
134609c 
Co-authored-by: Semyon Moroz <[email protected]>
@max-muoto @donbarbos
Update stdlib/asyncio/coroutines.pyi
5a4ac37 
Co-authored-by: Semyon Moroz <[email protected]>
@max-muoto @donbarbos
Update stdlib/asyncio/coroutines.pyi
cdf3e53 
Co-authored-by: Semyon Moroz <[email protected]>
@github-actions

This comment has been minimized.

Sign in to view
max-muoto added 2 commits December 26, 2025 13:43
@max-muoto
Add 3.14 deprecations
cbc3aee
@max-muoto
Trigger CI pipeline
66b70c0
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Dec 27, 2025
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also move the tests for the inspect functions to a new file check_inspect.py?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@max-muoto

max-muoto commented Dec 27, 2025

Copy link
Copy Markdown
Contributor Author

Could you also move the tests for the inspect functions to a new file check_inspect.py?

Will do.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@max-muoto
split up tests
300644c
@max-muoto

max-muoto commented Dec 27, 2025

Copy link
Copy Markdown
Contributor Author

Could you also move the tests for the inspect functions to a new file check_inspect.py?

Done: 300644c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@max-muoto
Merge branch 'main' into add-asyncio-deprecation
daab0fc
@github-actions

github-actions Bot commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

aiohttp (https://github.com/aio-libs/aiohttp)
+ aiohttp/web_urldispatcher.py:159:44: error: overload def [_P, _T] (func: def (*_P.args, **_P.kwargs) -> typing.Awaitable[_T`-2]) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, _T`-2]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.  [deprecated]
+ aiohttp/web_urldispatcher.py:159:44: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-deprecated for more info  [deprecated]
+ aiohttp/web_urldispatcher.py:167:44: error: overload def [_P, _T] (func: def (*_P.args, **_P.kwargs) -> typing.Awaitable[_T`-2]) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, _T`-2]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.  [deprecated]
+ aiohttp/worker.py:68:44: error: overload def [_P] (func: def (*_P.args, **_P.kwargs) -> builtins.object) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, Any]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.  [deprecated]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes Dec 28, 2025
View reviewed changes
@srittau
srittau merged commit 0338df4 into python:main Dec 28, 2025
63 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes
+1 more reviewer
@donbarbos donbarbos donbarbos left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@max-muoto @srittau @donbarbos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.