GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Protocol and runtime to typing_extensions by ilevkivskyi · Pull Request #1564 · python/typeshed

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Aug 19, 2017

Copy link
Copy Markdown
Member

This PR adds stubs for the changes to typing_extensions in python/typing#464

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ilevkivskyi added 2 commits August 19, 2017 15:48
@ilevkivskyi
Add Protocol and runtime to typing_extensions
c13805f
@ilevkivskyi
Use private type variable
bf6d2f7
@ilevkivskyi ilevkivskyi mentioned this pull request Aug 19, 2017
User-defined protocols python/mypy#3838
Closed
@ilevkivskyi
Fix typo
7ec92dd
@ilevkivskyi

ilevkivskyi commented Aug 19, 2017

Copy link
Copy Markdown
Member Author

Should I disable this flake8 error?

Y004 Version comparison must use only major and minor version

The comparison reflects the actual situation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ilevkivskyi
Bound type variable for runtime to only class objects
4724705
@Daenyth

Daenyth commented Aug 21, 2017

Copy link
Copy Markdown

I think the reasoning (don't use patch version checks) in CONTRIBUTING is pretty sound
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ilevkivskyi
Conform to version check specification
8beda74
@ilevkivskyi

ilevkivskyi commented Aug 21, 2017

Copy link
Copy Markdown
Member Author

@Daenyth Thanks, makes sense!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 42e2142 into python:master Aug 21, 2017
@ilevkivskyi
ilevkivskyi deleted the protocols-typing-extensions branch August 21, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ilevkivskyi @Daenyth @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.