GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add type stubs for the ``wave`` stdlib module to align with the Python 3.15 beta changes. by mbyrnepr2 · Pull Request #15824 · python/typeshed

Conversation

mbyrnepr2 commented May 22, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Jelle mentioned in this PR comment that he may produce this change as part of an AI-related task in the future.
I thought about leaving it at that but had a rethink and decided to just take responsibility for my own cPython update.

Tested locally with:

python -m mypy --custom-typeshed-dir <my local clone of typeshed> example.py

where example.py contains:

import wave

from pathlib import Path


AUDIO_FILE = Path("sound.wav")

with wave.open(AUDIO_FILE, "rb") as wave_read:
    pass

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mbyrnepr2 and others added 2 commits

May 22, 2026 11:13


          Add type stubs for the wave stdlib module to align with the Python

c79a28f

3.15 beta changes.


          [pre-commit.ci] auto fixes from pre-commit.com hooks

38c807d

This comment has been minimized.

mbyrnepr2 marked this pull request as ready for review

May 22, 2026 09:28

srittau requested changes

May 22, 2026

View reviewed changes

srittau left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also consider inlining the type alias, as I don't think it's overly necessary here, but I leave that decision to you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

stdlib/wave.pyi Outdated

		__all__ += ["WAVE_FORMAT_PCM", "WAVE_FORMAT_IEEE_FLOAT", "WAVE_FORMAT_EXTENSIBLE"]

		_File: TypeAlias = str \| IO[bytes]
		_File: TypeAlias = str \| IO[bytes] \| bytes \| PathLike[Any]

srittau May 22, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	_File: TypeAlias = str \| IO[bytes] \| bytes \| PathLike[Any]
	_File: TypeAlias = StrOrBytesPath \| IO[bytes]

(StrOrBytesPath needs to be imported from _typeshed.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mbyrnepr2 May 22, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that looks much more readable! Let's do it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Use StrOrBytesPath for improved readability/maintainability.

99a1185

Co-authored-by: Sebastian Rittau <[email protected]>

srittau previously approved these changes

May 22, 2026

View reviewed changes

srittau left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

srittau dismissed their stale review

May 22, 2026 09:55

I missed something.

srittau requested changes

May 22, 2026

View reviewed changes

srittau left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually missed something really important.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

stdlib/wave.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

This comment has been minimized.


          Update stdlib/wave.pyi

8b53be3

Co-authored-by: Sebastian Rittau <[email protected]>

This comment has been minimized.


          Merge branch 'main' into wave-stubs

66a4069

github-actions Bot commented May 22, 2026

Copy link

Copy Markdown

Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

srittau approved these changes

May 22, 2026

View reviewed changes

srittau merged commit df45287 into python:main

May 22, 2026

58 checks passed

Uh oh!

There was an error while loading. Please reload this page.

mbyrnepr2 deleted the wave-stubs branch

May 22, 2026 12:21

Reviewers

srittau

srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mbyrnepr2 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

srittau May 22, 2026

Choose a reason for hiding this comment

Uh oh!

mbyrnepr2 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented May 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mbyrnepr2 commented May 22, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.