GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Save the type if a subtype is passed to fnmatch.filter/fnmatch.filterfalse. by zedzhen · Pull Request #16647 · python/typeshed

Conversation

@zedzhen

@zedzhen zedzhen commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
zedzhen added 4 commits October 29, 2026 16:54
@zedzhen
Save the type if a subtype is passed to fnmatch.filter/fnmatch.filter…
b0475c7 
…false.
@zedzhen
Update fnmatch.pyi
c1a9d49
@zedzhen
fix name
f7ccf67
@zedzhen
Update fnmatch.pyi
a07243b
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Oct 29, 2026
View reviewed changes
Comment thread stdlib/fnmatch.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zedzhen
Update fnmatch.pyi
09a7901
srittau
srittau previously approved these changes Oct 29, 2026
View reviewed changes
JelleZijlstra
JelleZijlstra reviewed Oct 29, 2026
View reviewed changes
Comment thread stdlib/fnmatch.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra requested changes Oct 29, 2026
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@zedzhen
zedzhen requested a review from JelleZijlstra October 29, 2026 14:31
@zedzhen
Update fnmatch.pyi
c0cff08
@srittau
srittau dismissed their stale review October 29, 2026 14:38

Per Jelle

@github-actions

This comment has been minimized.

Sign in to view
zedzhen and others added 4 commits October 29, 2026 17:43
@zedzhen
Update fnmatch.pyi
a0a41cf
@zedzhen
Update fnmatch.pyi
971992d
@zedzhen
Update fnmatch.pyi
1888221
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bce0527
@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra approved these changes Oct 29, 2026
View reviewed changes
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 29, 2026
fnmatch.filter and filterfalse work with pathlikes only on non-Posix platforms python/cpython#160900
Open
zedzhen and others added 3 commits October 29, 2026 18:20
@zedzhen
in posix names can't have PathLike
14b40d6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bf18896
@zedzhen
Update fnmatch.pyi
aa6d139
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

setuptools (https://github.com/pypa/setuptools)
+ setuptools/glob.py:108: error: Unused "type: ignore[type-var, return-value]" comment  [unused-ignore]
+ setuptools/glob.py:108: error: Argument 1 to "filter" has incompatible type "list[str] | list[bytes]"; expected "Iterable[str]"  [arg-type]
+ setuptools/glob.py:108: note: Error code "arg-type" not covered by "type: ignore[type-var, return-value]" comment
+ setuptools/glob.py:108: error: Argument 2 to "filter" has incompatible type "str | bytes"; expected "str | PathLike[str]"  [arg-type]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zedzhen
zedzhen requested review from JelleZijlstra and srittau October 29, 2026 15:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra
@srittau srittau Awaiting requested review from srittau

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zedzhen @srittau @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.