GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Overload single_source/multi_source dijkstra and bellman_ford on target by chiliec · Pull Request #16746 · python/typeshed

Conversation

chiliec commented Nov 9, 2026

Copy link

Copy Markdown

Contributor

The single_source_dijkstra, multi_source_dijkstra and single_source_bellman_ford stubs returned the union tuple[dict, dict] | tuple[float, list], so callers had to narrow the result by hand even though the return shape is determined by whether target is passed. Each had a # TODO: overload on target note.

This splits each into two @overloads on target (None -> distances/paths dicts, a node -> distance/path), following the existing shortest_path overloads in generic.pyi, and removes the TODO comments.

Fixes #16744

Verified with the repo's own harness: added a test_cases file (check_single_source_target_overloads-py312.py) asserting both return shapes with assert_type — it failed before the change and passes after. pyright --project pyrightconfig.testcases.json on the networkx test_cases, mypy_test.py stubs/networkx, and stubtest (against networkx 3.6.1) all pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

chiliec and others added 2 commits

November 10, 2026 06:19


          Overload single_source/multi_source funcs on target

9b534e1

These three functions return (distance, path) when target is given and
(distances, paths) otherwise, but the stubs returned the union of both so
callers had to narrow manually. Split each into @overload on target,
mirroring the existing shortest_path overloads in generic.pyi, and drop the
stale # TODO: overload on target comments.

Fixes python#16744


          [pre-commit.ci] auto fixes from pre-commit.com hooks

github-actions Bot commented Nov 9, 2026

Copy link

Copy Markdown

Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TODOs in for nx.single_source_bellman_ford

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.