GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [parsimonious] Refine default_rule, grammar, and generic_visit types by sumit-2007-git · Pull Request #16772 · python/typeshed

Conversation

@sumit-2007-git

@sumit-2007-git sumit-2007-git commented Nov 11, 2026

Copy link
Copy Markdown

Replaces remaining Incomplete annotations and completes NodeVisitor.generic_visit in parsimonious:

  • parsimonious/grammar.pyi: type Grammar.default_rule as Expression | None (matches Grammar.__init__, where first may be None when no string-based rules are provided) and remove unused Incomplete import.
  • parsimonious/nodes.pyi: type NodeVisitor.grammar as Grammar | None (defaults to None at runtime), annotate NodeVisitor.generic_visit return type as Any, and remove unused Incomplete import.
  • pyrightconfig.stricter.json: remove stubs/parsimonious/parsimonious/nodes.pyi from exclusions as all parsimonious stubs now pass strict pyright.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sumit-2007-git
[parsimonious] Refine Grammar.default_rule, NodeVisitor.grammar, and …
6c87ca5 
…generic_visit types
@sumit-2007-git sumit-2007-git closed this Nov 11, 2026
@sumit-2007-git sumit-2007-git reopened this Nov 11, 2026
@github-actions

This comment has been minimized.

Sign in to view
@sumit-2007-git
Merge branch 'main' into fix/parsimonious-typing
85c6803
@github-actions

github-actions Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@sumit-2007-git
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.