GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add contextlib.AsyncContextDecorator by lancelote · Pull Request #5550 · python/typeshed

Conversation

@lancelote

@lancelote lancelote commented May 29, 2021

Copy link
Copy Markdown
Contributor

Yet another Python 3.10 addition - AsyncContextDecorator.

Links

  • Documentation: contextlib.AsyncContextDecorator
  • bpo-40816: Add missed AsyncContextDecorator to contextlib
  • PR bpo-40816 Add AsyncContextDecorator class cpython#20516: Add AsyncContextDecorator class

Async Function Annotation

I wasn't sure how to properly type annotate the func parameter. In the end, I followed

  • Document how to type hint for an async function used as a callback typing#424: Document how to type hint for an async function used as a callback
  • typeshed/stdlib/contextlib.pyi

    Line 91 in 33ea648

    _CallbackCoroFunc = Callable[..., Awaitable[Any]]

ContextDecorator

Existing ContextDecorator annotation for comparison

_F = TypeVar("_F", bound=Callable[..., Any])
class ContextDecorator:
    def __call__(self, func: _F) -> _F: ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lancelote
Add contextlib.AsyncContextDecorator
011a388
@github-actions

github-actions Bot commented May 29, 2021

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra
JelleZijlstra approved these changes May 29, 2021
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lancelote reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@JelleZijlstra
JelleZijlstra merged commit af376f4 into python:master May 29, 2021
@lancelote
lancelote deleted the async-ctx-dec branch May 29, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lancelote @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.