GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add `__(r)or__` to various `typing` classes by AlexWaygood · Pull Request #6498 · python/typeshed

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Dec 5, 2021

Copy link
Copy Markdown
Member
  • __(r)or__ has been added to ForwardRef in 3.11: https://bugs.python.org/issue45489.
  • __(r)or__ was added to TypeVar, ParamSpec and _SpecialForm in 3.10: https://bugs.python.org/issue41428 (this PR: https://github.com/python/cpython/pull/21515/files)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AlexWaygood added 5 commits December 3, 2021 17:18
@AlexWaygood
Add OrderedDict.fromkeys
c00a660 
Closes python#3800 (no other solution possible until we have higher-kinded `TypeVar`s)
@AlexWaygood
Add clarifying comments
f4ac71c
@AlexWaygood
Add __(r)or__ to various typing classes
2794d7f 
- `__or__` was added to `TypeVar` in Python 3.10: https://bugs.python.org/issue41428 (this PR: python/cpython#21515)
- `__or__` was added to `ForwardRef` in Python 3.11: https://bugs.python.org/issue45489
@AlexWaygood
Merge
ff86d05
@AlexWaygood
Merge remote-tracking branch 'origin/master' into patch-3
3bb94a6
@AlexWaygood

AlexWaygood commented Dec 5, 2021

Copy link
Copy Markdown
Member Author

^Sorry about the weird commit history there, I ran into conflicts between my local version of "patch-3" and my remote version of "patch-3".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Akuli

Akuli commented Dec 5, 2021

Copy link
Copy Markdown
Collaborator

It's ok, we have squash and merge :)
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
AlexWaygood reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit ff4bd7c into python:master Dec 5, 2021
@AlexWaygood
AlexWaygood deleted the patch-3 branch December 5, 2021 23:16
@AlexWaygood AlexWaygood mentioned this pull request Dec 16, 2021
New style unions and special forms #6219
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @Akuli @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.