GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix loop.remove_reader() and loop.remove_writer() signatures by asvetlov · Pull Request #7042 · python/typeshed

Conversation

@asvetlov

@asvetlov asvetlov commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

These methods return True if reader/writer was previously set, False otherwise.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asvetlov
Fix loop.remove_reader() and loop.remove_writer() signatures
7a3bfcc
@github-actions

github-actions Bot commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau

srittau commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

We should also change the return type in AbstractEventLoop.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov
Update AbstractEventLoop also
4d196fe
@asvetlov

asvetlov commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

Correct, thanks. Fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

tornado (https://github.com/tornadoweb/tornado)
+ tornado/platform/asyncio.py:641: error: Return type "None" of "remove_reader" incompatible with return type "bool" in supertype "AbstractEventLoop"
+ tornado/platform/asyncio.py:645: error: Return type "None" of "remove_writer" incompatible with return type "bool" in supertype "AbstractEventLoop"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov

asvetlov commented Jan 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Tornado is slightly incompatible with the reference asyncio implementation, sorry.
The boolean was returned from these methods starting from the very first asyncio release, please trust me :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes Jan 26, 2022
View reviewed changes
@srittau
srittau merged commit 98afaa4 into python:master Jan 26, 2022
@asvetlov
asvetlov deleted the fix-remove-reader-writer branch January 26, 2022 14:37
@AlexWaygood AlexWaygood mentioned this pull request Mar 9, 2022
Sync typeshed python/mypy#12321
Merged
@bdarnell bdarnell mentioned this pull request Nov 28, 2022
asyncio: Document return values of AbstractEventLoop.remove_{reader,writer} python/cpython#99830
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@asvetlov @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.