GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix return type for SymbolTable.get_identifiers by pamelafox · Pull Request #8054 · python/typeshed

Conversation

@pamelafox

@pamelafox pamelafox commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

Per my PR to cpython (python/cpython#93661), the documentation for SymbolTable.get_identifiers incorrectly says it returns a list, and thats what typeshed currently says as well.

This PR changes it to return dict_keys[str, int]

Here's code that shows get_identifiers in action:

>>> import symtable
>>> code = """
... def calc_pow(a, b):
...     return a ** b
... a = 1
... b = 2
... c = calc_pow(a,b)
... """
>>> 
>>> _st = symtable.symtable(code, "example.py", "exec")
>>> _st.get_identifiers()
dict_keys(['calc_pow', 'a', 'b', 'c'])
>>> _st.get_identifiers().mapping
mappingproxy({'calc_pow': 2066, 'a': 2066, 'b': 2066, 'c': 2050})

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pamelafox
Fix return type for SymbolTable.get_identifiers
18ecfbb
@pamelafox pamelafox mentioned this pull request Jun 10, 2022
SymbolTable.get_identifiers() docstring return value incorrect python/cpython#93660
Closed
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
179f500
@github-actions

github-actions Bot commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes Jun 10, 2022
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srittau
srittau merged commit b4c3e2c into python:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pamelafox @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.