GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — asyncio: improve bytes handling by JelleZijlstra · Pull Request #9013 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Oct 28, 2022

Copy link
Copy Markdown
Member

This depends partly on #8997 and should be merged after that PR.

A lot of asyncio code is hard to type because it consists of generic protocols without clear indications about expected types. Where necessary, I went with types from isinstance() checks in concrete classes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra and others added 2 commits October 27, 2022 20:38
@JelleZijlstra
asyncio: improve bytes handling
0429ea9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ccf3af7
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 28, 2022
Track review of bytes types #9006
Open
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Merge branch 'master' into asyncio
e317603
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
JelleZijlstra marked this pull request as ready for review October 28, 2022 13:52
srittau
srittau approved these changes Oct 28, 2022
View reviewed changes

@srittau srittau left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but I have two issues below where I'm unsure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/asyncio/streams.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/asyncio/windows_events.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits October 28, 2022 13:32
@JelleZijlstra
Address Sebastian feedback
266d679
@JelleZijlstra
I promised a comment
5ebbe62
@github-actions

github-actions Bot commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes Oct 28, 2022
View reviewed changes
@srittau
srittau merged commit 583b600 into python:master Oct 28, 2022
@JelleZijlstra
JelleZijlstra deleted the asyncio branch October 28, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.