GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ctypes: improve bytes handling by JelleZijlstra · Pull Request #9029 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Oct 29, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
ctypes: improve bytes handling
375bfc1
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 29, 2022
Track review of bytes types #9006
Open
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
ignore stubtest
d490fce
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau approved these changes Oct 31, 2022
View reviewed changes
Comment thread stdlib/ctypes/__init__.pyi

class c_char(_SimpleCData[bytes]):
def __init__(self, value: int | bytes = ...) -> None: ...
def __init__(self, value: int | bytes | bytearray = ...) -> None: ...

@srittau srittau Oct 31, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I failed to trace through the code for this, but I trust this is correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Oct 31, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find the code either but tried it in the REPL. This one allows bytearray but c_char_p doesn't.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/stubtest_allowlists/py3_common.txt Outdated
# Allowlist entries that cannot or should not be fixed
# ==========

ctypes.Array.raw # exists but stubtest can't see it

@srittau srittau Oct 31, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe copy the comment from the stub?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra
JelleZijlstra commented Oct 31, 2022
View reviewed changes
Comment thread tests/stubtest_allowlists/py3_common.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Update tests/stubtest_allowlists/py3_common.txt
956fb67
@github-actions

github-actions Bot commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau
srittau merged commit 3d8d744 into python:master Oct 31, 2022
@JelleZijlstra
JelleZijlstra deleted the ctypes branch October 31, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.