GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — hmac: improve bytes handling by sobolevn · Pull Request #9046 · python/typeshed

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

new and HMAC.__init__ accepts bytes | bytearray as the first argument: https://github.com/python/cpython/blob/87b5fd9d9de11c68b9940d3a1dba902138129109/Lib/hmac.py#L52

digest works with any ReadableBuffer:

>>> hmac.digest(bytearray(b''), bytearray(b''), 'md5')
b't\xe6\xf7)\x8a\x9c-\x16\x895\xf5\x8c\x00\x1b\xad\x88'
>>> hmac.digest(memoryview(b''), memoryview(b''), 'md5')
b't\xe6\xf7)\x8a\x9c-\x16\x895\xf5\x8c\x00\x1b\xad\x88'

>>> hmac.digest(bytearray(b''), memoryview(b''), 'md5')
b't\xe6\xf7)\x8a\x9c-\x16\x895\xf5\x8c\x00\x1b\xad\x88'
>>> hmac.digest(memoryview(b''), bytearray(b''), 'md5')
b't\xe6\xf7)\x8a\x9c-\x16\x895\xf5\x8c\x00\x1b\xad\x88'

And has len() call on itself: https://github.com/python/cpython/blob/87b5fd9d9de11c68b9940d3a1dba902138129109/Lib/hmac.py#L214

Refs #9006

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn and others added 2 commits October 31, 2022 15:29
@sobolevn
hmac: improve bytes handling
315d71f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4405e1f
@github-actions

github-actions Bot commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit ae75d68 into python:master Oct 31, 2022
@AlexWaygood AlexWaygood mentioned this pull request Oct 31, 2022
Track review of bytes types #9006
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.