GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — marshal: improve bytes handling by sobolevn · Pull Request #9047 · python/typeshed

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 31, 2022

Copy link
Copy Markdown
Member

Examples:

>>> import marshal
>>> marshal.loads(b'\xe9{\x00\x00\x00')
123
>>> marshal.loads(bytearray(b'\xe9{\x00\x00\x00'))
123
>>> marshal.loads(memoryview(b'\xe9{\x00\x00\x00'))
123

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
marshal: improve bytes handling
f791ce0
hauntsaninja
hauntsaninja approved these changes Oct 31, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood AlexWaygood mentioned this pull request Oct 31, 2022
Track review of bytes types #9006
Open
@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra reviewed Oct 31, 2022
View reviewed changes
Comment thread stdlib/marshal.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
sobolevn and others added 3 commits October 31, 2022 23:04
@sobolevn @JelleZijlstra
Update stdlib/marshal.pyi
f316f1e 
Co-authored-by: Jelle Zijlstra <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
93176a7
@sobolevn
Update marshal.pyi
724c330
JelleZijlstra
JelleZijlstra reviewed Oct 31, 2022
View reviewed changes
Comment thread stdlib/marshal.pyi Outdated
@@ -1,5 +1,5 @@
from _typeshed import ReadableBuffer

@JelleZijlstra JelleZijlstra Oct 31, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from _typeshed import ReadableBuffer
from _typeshed import ReadableBuffer, SupportsRead, SupportsWrite

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Oct 31, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you just did that, thanks! GitHub's UI doesn't handle this well: the "Commit" button still shows up on the suggestion but clicking it does nothing. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sobolevn sobolevn Oct 31, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra
JelleZijlstra approved these changes Oct 31, 2022
View reviewed changes
@github-actions

github-actions Bot commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 8036bbd into python:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @JelleZijlstra @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.