GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — plistlib: improve bytes handling by sobolevn · Pull Request #9048 · python/typeshed

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 31, 2022

Copy link
Copy Markdown
Member

dumps

>>> import plistlib
>>> plistlib.dumps(bytearray())
b'<?xml version="1.0" encoding="UTF-8"?>\n<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">\n<plist version="1.0">\n<data>\n</data>\n</plist>\n'
>>> plistlib.dumps(memoryview(b''))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/sobolev/.pyenv/versions/3.10.0/lib/python3.10/plistlib.py", line 901, in dumps
    dump(value, fp, fmt=fmt, skipkeys=skipkeys, sort_keys=sort_keys)
  File "/Users/sobolev/.pyenv/versions/3.10.0/lib/python3.10/plistlib.py", line 894, in dump
    writer.write(value)
  File "/Users/sobolev/.pyenv/versions/3.10.0/lib/python3.10/plistlib.py", line 325, in write
    self.write_value(value)
  File "/Users/sobolev/.pyenv/versions/3.10.0/lib/python3.10/plistlib.py", line 360, in write_value
    raise TypeError("unsupported type: %s" % type(value))
TypeError: unsupported type: <class 'memoryview'>

loads

>>> plistlib.loads(b'<?xml version="1.0" encoding="UTF-8"?>\n<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">\n<plist version="1.0">\n<integer>123</integer>\n</plist>\n')
123
>>> plistlib.loads(bytearray(b'<?xml version="1.0" encoding="UTF-8"?>\n<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">\n<plist version="1.0">\n<integer>123</integer>\n</plist>\n'))
123
>>> plistlib.loads(memoryview(b'<?xml version="1.0" encoding="UTF-8"?>\n<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">\n<plist version="1.0">\n<integer>123</integer>\n</plist>\n'))
123

readPlistFromBytes

It is using the same logic loads does: https://github.com/python/cpython/blob/948c6794711458fd148a3fa62296cadeeb2ed631/Lib/plistlib.py#L115-L123

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
plistlib: improve bytes handling
39693fe
@sobolevn
sobolevn force-pushed the bytes-plistlib branch from acb09b9 to 39693fe Compare October 31, 2022 20:03
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7d6ac55
@github-actions

github-actions Bot commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra
JelleZijlstra approved these changes Nov 1, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit 34e147f into python:master Nov 1, 2022
@AlexWaygood AlexWaygood mentioned this pull request Nov 1, 2022
Track review of bytes types #9006
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.