GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — imaplib: _Authenticator also works with bytearray by JelleZijlstra · Pull Request #9056 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Nov 1, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
imaplib: _Authenticator also works with bytearray
cb684eb
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 1, 2022
Track review of bytes types #9006
Open
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja requested changes Nov 1, 2022
View reviewed changes
Comment thread stdlib/imaplib.pyi Outdated
def __init__(self, mechinst: Callable[[bytes], bytes | bytearray | None]) -> None: ...
def process(self, data: str) -> str: ...
def encode(self, inp: bytes) -> str: ...
def encode(self, inp: bytes | bytearray) -> str: ...

@hauntsaninja hauntsaninja Nov 1, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is str | (Buffer & Sequence), e.g. don't see anything stopping memoryview from working here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/imaplib.pyi Outdated
def process(self, data: str) -> str: ...
def encode(self, inp: bytes) -> str: ...
def encode(self, inp: bytes | bytearray) -> str: ...
def decode(self, inp: str) -> bytes: ...

@hauntsaninja hauntsaninja Nov 1, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is str | _BufferWithLen

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/imaplib.pyi Outdated
class _Authenticator:
mech: Callable[[bytes], bytes]
def __init__(self, mechinst: Callable[[bytes], bytes]) -> None: ...
mech: Callable[[bytes], bytes | bytearray | None]

@hauntsaninja hauntsaninja Nov 1, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can return str as well

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srittau
Merge branch 'master' into imaplib
2469511
@github-actions

This comment has been minimized.

Sign in to view
@srittau
Merge branch 'master' into imaplib
dc908e9
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
imaplib: allow more types
8a08aae
@JelleZijlstra
JelleZijlstra requested a review from hauntsaninja November 3, 2022 03:37
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c6a6876
hauntsaninja
hauntsaninja approved these changes Nov 3, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja
hauntsaninja merged commit 460158f into python:main Nov 3, 2022
@JelleZijlstra
JelleZijlstra deleted the imaplib branch November 3, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JelleZijlstra @hauntsaninja @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.