GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — socket: constructor accepts bytes on Windows by JelleZijlstra · Pull Request #9095 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Nov 5, 2022

Copy link
Copy Markdown
Member

https://github.com/python/cpython/blob/d04899abb0da4cc7c0a390f5bc52d57ace8955fd/Modules/socketmodule.c#L5318

This is used in socket.fromshare. It must be bytes, not some other buffer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra and others added 2 commits November 4, 2022 18:32
@JelleZijlstra
socket: constructor accepts bytes on Windows
01f9631 
https://github.com/python/cpython/blob/d04899abb0da4cc7c0a390f5bc52d57ace8955fd/Modules/socketmodule.c#L5318

This is used in `socket.fromshare`. It must be bytes, not some other buffer.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b72cd62
@github-actions

github-actions Bot commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 5, 2022
Track review of bytes types #9006
Open
@AlexWaygood

AlexWaygood commented Nov 10, 2022

Copy link
Copy Markdown
Member

It took me a while, but I finally managed to find a REPL snippet that demonstrates that this is indeed the case on my Windows machine (there might be a simpler way of demonstrating this, idk):

>>> import socket, multiprocessing
>>> sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
>>> p = multiprocessing.Process()
>>> foo = sock.share(p._parent_pid)
>>> type(foo)
<class 'bytes'>
>>> socket.socket(fileno=foo)
<socket.socket fd=168, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Nov 10, 2022
View reviewed changes
@AlexWaygood
AlexWaygood merged commit c7820b4 into python:main Nov 10, 2022
@JelleZijlstra
JelleZijlstra deleted the sock branch November 10, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.