GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — socketserver: improve bytes handling by JelleZijlstra · Pull Request #9096 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Nov 5, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
socketserver: improve bytes handling
3f4fd9c
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 5, 2022
Track review of bytes types #9006
Open
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra

JelleZijlstra commented Nov 5, 2022

Copy link
Copy Markdown
Member Author

hm, since these are mostly for subclasses, making the address types precise is probably mostly a hassle for subclassers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra and others added 2 commits November 4, 2022 19:10
@JelleZijlstra
use _RetAddress (which is Any, shhh)
e6d4802
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
51b6f69
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
fix http.server
da9d3e8
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood requested changes Nov 25, 2022
View reviewed changes
Comment thread stdlib/socketserver.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/socketserver.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/socketserver.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/socketserver.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/socketserver.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra and others added 4 commits January 11, 2023 19:13
@JelleZijlstra
Merge branch 'main' into socketserver
d610470
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6aa1e52
@JelleZijlstra
Feedback from Alex
dc9c7da
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
360e1cf
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
ignore
2b40731
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood added 4 commits January 12, 2023 13:01
@AlexWaygood
Update server.pyi
59fc621
@AlexWaygood
One more nit
bb8aacb
@AlexWaygood
oops
29478d0
@AlexWaygood
Merge branch 'main' into socketserver
4e81d85
AlexWaygood
AlexWaygood reviewed Jan 12, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just one more question: Should the BaseServer.server_address attribute (on line 39) also be changed to be _socket._Address, to match the type passed in __init__?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
consistent server_address
578f8d2
AlexWaygood
AlexWaygood approved these changes Jan 12, 2023
View reviewed changes
@github-actions

github-actions Bot commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood merged commit f64807a into python:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.