GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — xml: improve bytes types by JelleZijlstra · Pull Request #9110 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Nov 5, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
xml: improve bytes types
5efcc3b
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 5, 2022
Track review of bytes types #9006
Open
@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra and others added 2 commits November 6, 2022 07:10
@JelleZijlstra
one more
bb033c0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
000f78b
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja reviewed Nov 11, 2022
View reviewed changes
Comment thread stdlib/xml/dom/expatbuilder.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/xml/etree/ElementTree.pyi
def data(self, __data: str) -> None: ...
# tag and attrs are passed to the element_factory, so they could be anything
# depending on what the particular factory supports.
def start(self, __tag: Any, __attrs: dict[Any, Any]) -> Element: ...

@hauntsaninja hauntsaninja Nov 11, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth keeping the comment, but only changing the type if someone actually complains?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Nov 11, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing type is pretty hard to achieve due to invariance, so I'd rather not keep it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra @hauntsaninja
Update stdlib/xml/dom/expatbuilder.pyi
b3bc6c1 
Co-authored-by: Shantanu <[email protected]>
hauntsaninja
hauntsaninja approved these changes Nov 11, 2022
View reviewed changes
@github-actions

github-actions Bot commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit ec4ec33 into python:main Nov 11, 2022
@JelleZijlstra
JelleZijlstra deleted the xmlbyttes branch November 11, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.