GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update SimpleHTTPRequestHandler by ethanfurman · Pull Request #9452 · python/typeshed

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jan 3, 2023

Copy link
Copy Markdown
Member

The index_pages parameter has been removed from __init__ as subclassing is the encouraged method for modifying SimpleHttpRequestHandler.

index_pages should be a tuple of 0 or more strings (not sure I have the type hint correct).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ethanfurman
update SimpleHTTPRequestHandler
5a3e3b1
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood

AlexWaygood commented Jan 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The index_pages parameter has been removed from __init__ as subclassing is the encouraged method for modifying SimpleHttpRequestHandler.

But the parameter does nonetheless exist on the CPython main branch, no? :) https://github.com/python/cpython/blob/64ed609c532a12b27f67a1e12e9e02f136ee3a94/Lib/http/server.py#L664

We tend to be descriptive rather than prescriptive in typeshed. If a parameter exists at runtime, we tend to include it in the stub, even if it's not considered great style to use that parameter at runtime. If we do otherwise, people tend to complain loudly at us. It also means we have to switch off some of our tests that check that the stub is consistent with the runtime, and switching off those tests means our stubs become vulnerable to silently growing out of date without us noticing.

(You don't see those tests failing on this PR because we haven't switched them on yet for 3.12, since 3.12 is still in development.)

JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman

ethanfurman commented Jan 3, 2023

Copy link
Copy Markdown
Member Author

PR changing __init__ has now been merged. :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Jan 3, 2023

Copy link
Copy Markdown
Member

PR changing __init__ has now been merged. :-)

Ah! I didn't realise there was a pending PR :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented Jan 3, 2023

Copy link
Copy Markdown
Member

Maybe we're being a bit early with the 3.12 features here :) We can make this change though now that main has been changed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra
JelleZijlstra approved these changes Jan 3, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Jan 3, 2023
View reviewed changes
Comment thread stdlib/http/server.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman @AlexWaygood
use ClassVar
0c4c4b0
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Jan 3, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions

github-actions Bot commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood
AlexWaygood merged commit 3aceb1a into python:main Jan 3, 2023
@ethanfurman
ethanfurman deleted the http branch January 4, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ethanfurman @AlexWaygood @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.