GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — conformance: do not require error for Final + ClassVar by JelleZijlstra · Pull Request #2373 · python/typing

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Oct 20, 2026

Copy link
Copy Markdown
Member

And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation
already tests it in a more isolated way.

Fixes #2371.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dangotbanned reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@JelleZijlstra
conformance: do not require error for Final + ClassVar
ae7fbdf 
And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation
already tests it in a more isolated way.

Fixes python#2371.
jorenham
jorenham approved these changes Oct 20, 2026
View reviewed changes

@jorenham jorenham left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; thanks :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
carljm
carljm approved these changes Oct 20, 2026
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread conformance/tests/qualifiers_final_annotation.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread conformance/tests/classes_classvar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread conformance/tests/qualifiers_final_annotation.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits October 20, 2026 14:16
@JelleZijlstra
feedback
6d3595a
@JelleZijlstra
regen
bc8250a
carljm
carljm approved these changes Oct 20, 2026
View reviewed changes
@davidhalter davidhalter mentioned this pull request Oct 21, 2026
ClassVar + Final #2371
Open
rchen152
rchen152 approved these changes Oct 28, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@rchen152 rchen152 rchen152 approved these changes
@jorenham jorenham jorenham approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ClassVar + Final

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @carljm @rchen152 @jorenham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.