GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add some tests based on coverage report: Part 1 by ilevkivskyi · Pull Request #373 · python/typing

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Jan 27, 2017

Copy link
Copy Markdown
Member

I have run coverage on typing and have noticed that some statements are missing. Most of them are trivial, but some are interesting to test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ilevkivskyi
Add some tests based on coverage report
a82976b
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 27, 2017
@ilevkivskyi
Fix lint
6e0165d
@ilevkivskyi ilevkivskyi mentioned this pull request Jan 28, 2017
Add some tests based on coverage report: Part 2 #375
Merged
JelleZijlstra
JelleZijlstra approved these changes Jan 28, 2017
View reviewed changes
@ilevkivskyi

ilevkivskyi commented Feb 1, 2017

Copy link
Copy Markdown
Member Author

This just adds tests, so that I think it is safe to merge now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ilevkivskyi
ilevkivskyi merged commit d149ce7 into python:master Feb 1, 2017
@ilevkivskyi
ilevkivskyi deleted the more-test-cov branch February 1, 2017 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ilevkivskyi @JelleZijlstra @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.